Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update DEVELOPING and IMPLEMENTATION docs with new ossmc info #700

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jmazzitelli
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmazzitelli jmazzitelli merged commit 7657327 into kiali:master Oct 24, 2023
1 check passed
@jmazzitelli jmazzitelli deleted the fix-link branch October 24, 2023 15:34

NOTE: The KO needs to periodically update its Ansible Operator SDK base image. To see how this is done, just do the same things done previously (see link:https://github.com/kiali/kiali/issues/6220[this issue] and link:https://github.com/kiali/kiali-operator/pull/657/files[this PR] as good examples of what needs to be done).

== Multiple Version Support

The KO can support installing multiple versions of the Kiali server by invoking different versions of the Ansible roles. The versions the KO supports are defined in link:https://github.com/kiali/kiali-operator/blob/v1.69.0/playbooks/default-supported-images.yml[default-supported-images.yml]. For each version supported, there is an link:https://github.com/kiali/kiali-operator/tree/v1.69.0/roles[Ansible role] that the KO executes when it needs to install or remove that Kiali version.
The KO can support installing multiple versions of the Kiali server and OSSMC by invoking different versions of the Ansible roles. The versions the KO supports are defined in link:https://github.com/kiali/kiali-operator/blob/master/playbooks/kiali-default-supported-images.yml[kiali-default-supported-images.yml] and (for OSSMC) in link:https://github.com/kiali/kiali-operator/blob/master/playbooks/ossmconsole-default-supported-images.yml[ossmconsole-default-supported-images.yml]. For each version supported, there is an link:https://github.com/kiali/kiali-operator/tree/master/roles[Ansible role] that the KO executes when it needs to install or remove that Kiali or OSSMC version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kiali and OSSMC versions must be the same, right, they are linked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, today they need to be linked.

@@ -2,65 +2,70 @@

This document describes the current state of the implementation of the Kiali Operator (henceforce, "KO"). The purpose for this document is to provide an introduction to the internals of the KO to those who have a need to modify or enhance the KO.

NOTE: This document reflects the current implementation as of release link:https://github.com/kiali/kiali-operator/tree/v1.69.0[v1.69.0]
NOTE: This document reflects the current implementation as of release link:https://github.com/kiali/kiali-operator/tree/v1.76.0[v1.76.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch doesn't exist yet. In general, some entries here are for 1.76, some for 1.75 and some for master, is that all intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I just put that in there for now- we'll get that branch in a week

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of this was intentional - master intentional.. 1.75 intentional because I don't have .76 yet but those files aren't changing between 75->76 so its good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants