Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

while processing OSSMConsole CR, operator should retry a few times before giving up getting the kiali version #731

Merged
merged 1 commit into from
Dec 14, 2023
Merged

while processing OSSMConsole CR, operator should retry a few times before giving up getting the kiali version #731

merged 1 commit into from
Dec 14, 2023

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli self-assigned this Dec 12, 2023
@jmazzitelli jmazzitelli force-pushed the 6950-fix-version branch 2 times, most recently from bcb473e to 13888a2 Compare December 12, 2023 19:09
@jmazzitelli jmazzitelli marked this pull request as ready for review December 12, 2023 19:28
@jmazzitelli
Copy link
Contributor Author

Tested and it works.

Quick test is to install Istio and then Kiali. Then scale down the deployment to 0 pods so a kiali pod isn't running. Then install an OSSMConsole CR and look at the operator logs. You'll see it start to loop retrying to get kiali version info. Scale up the kiali deployment to 1 so a pod starts and then eventually you should see the operator continue processing the OSSMConsole CR and the CR's status field will show the kiali version.

@jmazzitelli jmazzitelli mentioned this pull request Dec 12, 2023
Merged
@jmazzitelli jmazzitelli changed the title operator should retry a few times before giving up getting the kiali version while processing OSSMConsole CR, operator should retry a few times before giving up getting the kiali version Dec 14, 2023
jshaughn
jshaughn approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, OSSMC depends on Kiali, it should do its best to wait for Kiali, but not wait forever, just in case someone is determined to install the plugin first.

@jmazzitelli jmazzitelli merged commit 63ff05b into kiali:master Dec 14, 2023
1 check passed
@jmazzitelli jmazzitelli deleted the 6950-fix-version branch December 14, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
None yet
Projects
Kiali Sprint 25-01 | Kiali v2.4
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kiali operator cannot determine kiali version when installing ossmc
2 participants
@jmazzitelli @jshaughn