Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top level clustering field #734

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Add top level clustering field #734

merged 3 commits into from
Jan 12, 2024

Conversation

nrfox
Copy link
Contributor

@nrfox nrfox commented Jan 11, 2024

Adds a top level clustering field to the kiali spec.

Relates to kiali/kiali#6243

@nrfox nrfox marked this pull request as ready for review January 11, 2024 19:25
@nrfox nrfox mentioned this pull request Jan 11, 2024
Merged
@nrfox nrfox requested a review from jmazzitelli January 11, 2024 19:25
jmazzitelli
jmazzitelli previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a trivial thing but I approve

roles/default/kiali-deploy/vars/main.yml Outdated Show resolved Hide resolved
@nrfox @jmazzitelli
Update roles/default/kiali-deploy/vars/main.yml
3b785a4 
Co-authored-by: John Mazzitelli <mazz@redhat.com>
@nrfox nrfox merged commit 2a9fab5 into kiali:master Jan 12, 2024
1 check passed
@nrfox nrfox deleted the kiali-6243 branch January 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmazzitelli jmazzitelli jmazzitelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrfox @jmazzitelli