Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tempo grafana datasource settings #749

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

josunect
Copy link
Contributor

For the new Grafana URL format, Kiali will need to know the Grafana Tempo Datasource UID and the org Id in order to generate the trace/span links.

Ref. kiali/kiali#7085

@josunect josunect added the enhancement New feature or request label Mar 14, 2024
@josunect josunect self-assigned this Mar 14, 2024
@josunect josunect requested a review from jmazzitelli March 15, 2024 08:16
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetize ;)

crd-docs/cr/kiali.io_v1alpha1_kiali.yaml Outdated Show resolved Hide resolved
crd-docs/crd/kiali.io_kialis.yaml Outdated Show resolved Hide resolved
roles/default/kiali-deploy/defaults/main.yml Outdated Show resolved Hide resolved
josunect and others added 3 commits March 15, 2024 16:12
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
@josunect
Copy link
Contributor Author

alphabetize ;)

Right!

@jshaughn jshaughn added the requires docs PR Requires kiali.io or other documentation updates label Mar 15, 2024
@jmazzitelli jmazzitelli merged commit 27ab5ff into kiali:master Mar 19, 2024
1 check passed
@josunect josunect deleted the issue7085 branch March 20, 2024 07:36
@josunect
Copy link
Contributor Author

Doc PR: kiali/kiali.io#764

@jshaughn jshaughn added the test: n/a PR does not need test additions or updates label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requires docs PR Requires kiali.io or other documentation updates test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

3 participants