-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new graph setting for the animation style #851
Conversation
Co-authored-by: John Mazzitelli <mazz@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to add the default to the example CR, and I just noticed we are missing all of the settings here. So you should add them. This example CR file is used for 2 things (a) for an example CR that users can refer to, each value in the example CR file is the default, so users can use this as a reference for all default values, and
(b) this file is used to test the schema validation - our CI action runs a validation test on the example CR which confirms the schema and example files are both valid.
So in this file: https://github.com/kiali/kiali-operator/blob/v2.1.0/crd-docs/cr/kiali.io_v1alpha1_kiali.yaml#L437
you need to add this:
settings:
animation: "point"
font_label: 13
min_font_badge: 7
min_font_label: 10
I will add the new one, but the others are actually purposefully unadvertised, and also will go away with the cytoscape Having said that, I see that we are missing:
I'll add that, too. |
- add missing settings
Now that CR validation failed.
|
Flibbedy floo, looks like the ambient setting was missing all over the place. I'll add it. |
- now need to add other missing ambient traffic entries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validation passes. lgtm
Part-of kiali/kiali#7934