Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Change homepage url inside package.json #26

Merged
merged 4 commits into from
Feb 22, 2018

Conversation

mtho11
Copy link
Contributor

@mtho11 mtho11 commented Feb 19, 2018

Change homepage url in package.json to be swift-sunshine instead of mtho11.

@josejulio
Copy link
Contributor

josejulio commented Feb 19, 2018

I'm not sure if that's the right way to use homepage on a React app.
It appears as if homepage is used to define the homepage for the actual running application help with relative paths.

See here and here

@jotak
Copy link
Contributor

jotak commented Feb 21, 2018

This is weird. See https://docs.npmjs.com/files/package.json#homepage
It looks like a misappropriation of this config flag by create-react-app

Btw, I still haven't understood, are we using create-react-app or not?

@josejulio
Copy link
Contributor

This is weird. See https://docs.npmjs.com/files/package.json#homepage
It looks like a misappropriation of this config flag by create-react-app

Agree

Btw, I still haven't understood, are we using create-react-app or not?

It seems so, see this old README

@mtho11
Copy link
Contributor Author

mtho11 commented Feb 21, 2018

@jotak yes this project was created using create-react-app-ts
Hopefully, we won't have to eject the webpack config.

@mtho11
Copy link
Contributor Author

mtho11 commented Feb 21, 2018

Changed to relative urls.

@jmazzitelli jmazzitelli merged commit c53ad01 into kiali:master Feb 22, 2018
@mtho11 mtho11 deleted the homepage-url branch February 22, 2018 01:15
@mtho11
Copy link
Contributor Author

mtho11 commented Feb 22, 2018

@mwringe so version 0.2.4 has the relative url changes

mtho11 added a commit that referenced this pull request Sep 25, 2019
…ove to PF4) (#1418)

* #1620 Make graph legend more obvious to scroll. Migrate to PF4.

* Try to fix scrollbar issue that occurs on Fedora

* - apply same approach as used in graph find help (#26)

* Remove the unused constructor and add new test snapshot.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants