Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LeftHand TOC issue (caused by readfile) #714

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

jshaughn
Copy link
Contributor

@jshaughn jshaughn commented Nov 2, 2023

Fixes kiali/kiali#6787

  • replace readfile with custom shortcode for maistra compat be like what we have for istio compat
  • fix weights for Installation section

https://deploy-preview-714--kiali.netlify.app/docs/installation/installation-guide/prerequisites/#maistra-version-compatibility

- replace readfile with custom shortcode for maistra compat be like
  what we have for istio compat
- fix weights for Installation section
@jshaughn jshaughn self-assigned this Nov 2, 2023
@jshaughn jshaughn requested a review from jmazzitelli November 2, 2023 20:54
@jshaughn jshaughn assigned jshaughn and unassigned jshaughn Nov 2, 2023
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jshaughn jshaughn merged commit 5af4989 into kiali:staging Nov 3, 2023
4 checks passed
@jshaughn jshaughn deleted the kiali6787 branch November 3, 2023 15:35
hhovsepy pushed a commit to hhovsepy/kiali.io that referenced this pull request Apr 5, 2024
- replace readfile with custom shortcode for maistra compat be like
  what we have for istio compat
- fix weights for Installation section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

empty tree entry in kiali.io installation menu and goes to incorrect place
2 participants