-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tempo docs #735
Update tempo docs #735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josunect In addition to my suggestions below, there is one other thing I would like to change but it isn't touched in this PR so github won't let me comment on it directly. It is line 114 that says this:
The `in_cluster_url` Kiali option needs to be set to'
`http://query-frontend.tempo.svc.cluster.local:16685`.
It isn't clear to the reader what this in_cluster_url
setting is (and even I'm not 100% sure - I think this is the tracing in_cluster_url, right???). Can we change this to be more specific; something like this (also notice there was an extra '
character here at the end of the line that should be deleted and replaced with the :
(colon) character):
The `external_services.tracing.in_cluster_url` Kiali option needs to be set to:
`http://query-frontend.tempo.svc.cluster.local:16685`.
content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
Outdated
Show resolved
Hide resolved
content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
Outdated
Show resolved
Hide resolved
content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
Outdated
Show resolved
Hide resolved
content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
Outdated
Show resolved
Hide resolved
content/en/docs/Configuration/p8s-jaeger-grafana/tracing/tempo.md
Outdated
Show resolved
Hide resolved
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Yes, right, that is the tracing section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update tempo docs --------- Co-authored-by: John Mazzitelli <mazz@redhat.com>
Fixes kiali/kiali#6952
https://deploy-preview-735--kiali.netlify.app/docs/configuration/p8s-jaeger-grafana/tracing/tempo/