Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo upgrade to 0.121. Docsy update #740

Merged
merged 14 commits into from
Jan 8, 2024
Merged

Conversation

josunect
Copy link
Contributor

@josunect josunect commented Jan 3, 2024

https://deploy-preview-740--kiali.netlify.app/

@josunect josunect added the enhancement New feature or request label Jan 3, 2024
@josunect josunect self-assigned this Jan 3, 2024
@josunect josunect marked this pull request as ready for review January 4, 2024 11:35
@hhovsepy hhovsepy self-requested a review January 4, 2024 13:30
Copy link
Contributor

@hhovsepy hhovsepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, checked all pages, no regression

@ferhoyos
Copy link
Contributor

ferhoyos commented Jan 5, 2024

Great update @josunect, it was really needed. One question, have you updated devDependencies autoprefixer and postcss-cli? With +5000 file changes I am not able to check it (browser hangs)

@josunect
Copy link
Contributor Author

josunect commented Jan 5, 2024

@ferhoyos no, it was not updated.

@ferhoyos
Copy link
Contributor

ferhoyos commented Jan 5, 2024

Ok, as we are updating kiali.io stuff, I think it would be a good moment to update them too (postcss has security vulnerability). Since the PR has been already reviewed by @hhovsepy, it can be done afterwards.

According to docsy documentation:

Starting in version 8 of postcss-cli, you must also separately install postcss

npm install -D postcss

@josunect
Copy link
Contributor Author

josunect commented Jan 5, 2024

Ok, as we are updating kiali.io stuff, I think it would be a good moment to update them too (postcss has security vulnerability). Since the PR has been already reviewed by @hhovsepy, it can be done afterwards.

According to docsy documentation:

Starting in version 8 of postcss-cli, you must also separately install postcss

npm install -D postcss

I've updated the version for the dev dependencies.

@josunect josunect merged commit d7b3029 into kiali:staging Jan 8, 2024
5 checks passed
@josunect josunect deleted the hugo_upgrade branch January 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants