Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docsy on make serve command #757

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

ferhoyos
Copy link
Contributor

@ferhoyos ferhoyos commented Feb 13, 2024

Trying to deploy kiali.io site locally with make serve command, I found the following error:

Error: command error: failed to load modules: module "github.com/FortAwesome/Font-Awesome" not found in "/site/themes/github.com/FortAwesome/Font-Awesome"; either add it as a Hugo Module or store it in "/site/themes".: module does not exist

Although I found a workaround with #756, afterwards I noticed that validate-site command was working, and the difference with make serve is the docsy build

cd themes/docsy && npm install && cd ../..

Doing the docsy build on make serve does the trick, and it is a better solution than #756

@ferhoyos ferhoyos requested a review from josunect February 13, 2024 11:39
@ferhoyos ferhoyos self-assigned this Feb 13, 2024
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this failed for me the first time, but succeeded the second. The failure was this:

$ make serve
Will not rebuild the image [kiali/hugo:latest].
npm notice 
npm notice New minor version of npm available! 10.2.4 -> 10.4.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.4.0
npm notice Run npm install -g npm@10.4.0 to update!
npm notice 
npm ERR! code ETIMEDOUT
npm ERR! errno ETIMEDOUT
npm ERR! network request to https://registry.npmjs.org/is-stream/-/is-stream-3.0.0.tgz failed, reason: 
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2024-02-13T12_55_59_775Z-debug-0.log
make: *** [Makefile:49: serve] Error 1

So it is possible that you might need to run it a second time to get this to work.

@ferhoyos
Copy link
Contributor Author

Or maybe it is just a simple network timeout from your side :-)

@ferhoyos ferhoyos merged commit 0953379 into kiali:staging Feb 13, 2024
5 checks passed
@ferhoyos ferhoyos deleted the build-docsy branch February 13, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants