Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalization feature docs #762

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Internationalization feature docs #762

merged 9 commits into from
Mar 21, 2024

Conversation

ferhoyos
Copy link
Contributor

@ferhoyos ferhoyos commented Mar 6, 2024 •
edited
Loading

@ferhoyos ferhoyos self-assigned this Mar 6, 2024
@ferhoyos ferhoyos marked this pull request as ready for review March 20, 2024 17:40
jmazzitelli
jmazzitelli requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor fixes. All looks good otherwise.

One thing we might want to have in here: Do we want to ask for community contributions for new languages? We could provide a link to another page that tells people how they can add new language translations which they can then submit as a PR.

jshaughn
jshaughn requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A few minor suggestions. Also, do we want to add a link to your README developer docs on I18N on github? (I know that's not merged yet, but it will be).

@ferhoyos ferhoyos marked this pull request as draft March 21, 2024 07:34
@ferhoyos ferhoyos mentioned this pull request Mar 21, 2024
Merged
ferhoyos and others added 7 commits March 21, 2024 08:41
@ferhoyos @jmazzitelli
Update content/en/docs/Features/internationalization.md
0e4f920 
Co-authored-by: John Mazzitelli <mazz@redhat.com>
@ferhoyos @jmazzitelli
Update content/en/docs/Features/internationalization.md
ebe074e 
Co-authored-by: John Mazzitelli <mazz@redhat.com>
@ferhoyos @jmazzitelli
Update content/en/docs/Features/internationalization.md
1b13569 
Co-authored-by: John Mazzitelli <mazz@redhat.com>
@ferhoyos @jshaughn
Update content/en/docs/Features/internationalization.md
67ee4b9 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@ferhoyos @jshaughn
Update content/en/docs/Features/internationalization.md
0895206 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@ferhoyos
Add a collaboration statement in the i18n page
df4e150
@ferhoyos
Modify collaboration statement
b7d7366
@ferhoyos ferhoyos marked this pull request as ready for review March 21, 2024 08:58
@ferhoyos
Copy link
Contributor Author

Thank you @jshaughn and @jmazzitelli for your feedback! It is good to have English native speakers in the team :-)

As suggested by you, I have added a link to the frontend developments docs if someone wants to collaborate on the internationalization of Kiali.

jshaughn
jshaughn approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@jshaughn jshaughn merged commit 5d206c0 into kiali:staging Mar 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmazzitelli jmazzitelli jmazzitelli approved these changes

@jshaughn jshaughn jshaughn approved these changes

Assignees

@ferhoyos ferhoyos

Labels
None yet
Projects
Kiali Sprint 25-04 | Kiali v2.7
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferhoyos @jmazzitelli @jshaughn