Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Install via Helm. #765

Merged
merged 3 commits into from
Mar 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ command:
$ helm install \
--set cr.create=true \
--set cr.namespace=istio-system \
--set cr.auth.strategy="anonymous" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault. I did not properly review this PR.

This is wrong and does nothing to affect the strategy. It should have been:

    --set cr.spec.auth.strategy="anonymous" \

(note the missing .spec)

--namespace kiali-operator \
--create-namespace \
kiali-operator \
Expand All @@ -80,7 +81,10 @@ create the `kiali-operator` namespace (if needed), and deploy the Kiali
operator on it. The `--set cr.create=true` and `--set
cr.namespace=istio-system` flags instructs to create a Kiali CR in the
`istio-system` namespace. Since the Kiali CR is created in advance, as soon as
the Kiali operator starts, it will process it to deploy Kiali.
the Kiali operator starts, it will process it to deploy Kiali. After Kiali has started,
you can access Kiali UI through 'http://localhost:20001' by executing
`kubectl port-forward service/kiali -n istio-system 20001:20001`
because of `--set cr.auth.strategy="anonymous"`. But realize that anonymous mode will allow anyone to be able to see and use Kiali. If you wish to require users to authenticate themselves by logging into Kiali, use one of the other [auth strategies](/docs/configuration/authentication/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here, too - should be "cr.spec.auth.strategy"

Copy link
Contributor Author

@chickenchickenlove chickenchickenlove Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmazzitelli sorry to bother you.
you right, i missed it. I'm really sorry.
From this, as you said, cr.auth.strategy="anonymous" should be change to cr.spec.auth.strategy="anonymous", i think.

May i create new PR to fix it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
Thanks for your help. 🙇‍♂️


The Kiali Operator Helm Chart is configurable. Check available options and default values by running:

Expand Down
Loading