Added new Warning message KIA0107 #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josunect
reviewed
Apr 10, 2024
josunect
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Just a comment, but I would think on this rule more like an info message, because maybe the user don't want to see a warning if this result that the SPIRE configuration is right. But I guess this will be validated once the SPIRE support is added to Kiali, right?
|
@josunect thanks for the review, I think we can leave it as 'warning' for now as it is temporary before SPIFFY support is implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue kiali/kiali#7152
Core PR kiali/kiali#7258