Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update KIA0207 example #778

Merged
merged 1 commit into from
Apr 23, 2024
Merged

update KIA0207 example #778

merged 1 commit into from
Apr 23, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 17, 2024

policy is no longer exists in istio, update the demo with PeerAuthentication

Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no github issue associated with this PR. In addition, there are no details -- what is the problem you are seeing? How do you reproduce the problem? What version of Kiali? What version of Istio? etc. etc.

Prior to submitting a PR, please submit a github issue explaining the problem, as per the community contribution guidelines specified here: https://github.com/kiali/kiali/blob/master/CONTRIBUTING.md#making-a-change

@zirain zirain closed this Apr 17, 2024
@zirain zirain deleted the update-kia0207 branch April 17, 2024 01:55
@jshaughn
Copy link
Contributor

@zirain , please re-open the PR if it's valid for the currently supported versions of Istio. We just wanted to make sure it was applicable to all of the Istio versions supported by the latest version of Kiali.

@zirain zirain restored the update-kia0207 branch April 17, 2024 13:27
@zirain zirain reopened this Apr 17, 2024
@zirain
Copy link
Contributor Author

zirain commented Apr 17, 2024

@zirain , please re-open the PR if it's valid for the currently supported versions of Istio. We just wanted to make sure it was applicable to all of the Istio versions supported by the latest version of Kiali.

I'm pretty sure that policy is no long valid for a long time.

@jshaughn
Copy link
Contributor

cc @hhovsepy

@hhovsepy hhovsepy self-requested a review April 23, 2024 10:36
@hhovsepy
Copy link
Contributor

thanks @zirain for the catch, I confirm that the docs were outdated with KIA0207

@hhovsepy hhovsepy merged commit 2c0dfca into kiali:staging Apr 23, 2024
5 checks passed
@zirain zirain deleted the update-kia0207 branch April 23, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants