ComponentStatus Components made empty. #805
Conversation
There was a problem hiding this comment.
This is modifying the wrong file. This is modifying a generated file. Close this PR (do not merge it) and the files you want to change are here in the operator repo:
- https://github.com/kiali/kiali-operator/blob/master/crd-docs/crd/kiali.io_kialis.yaml
- https://github.com/kiali/kiali-operator/blob/master/crd-docs/cr/kiali.io_v1alpha1_kiali.yaml
See the DEVELOPING doc with the links : https://github.com/kiali/kiali-operator/blob/master/DEVELOPING.adoc#are-you-altering-a-kiali-server-configuration-setting
| enabled: true | ||
| config_map_name: "istio" | ||
| # default egress_gateway_namespace is undefined |
There was a problem hiding this comment.
It isn't true that it is undefined - the default (as created by the operator) is empty string as you have in the new PR here. So what you have here is the literal default (the defaults we are defining here in this file are the defaults assigned to the server by the operator)
That said you are modifying the wrong file. Do not modify this file, it is autogenerated.
| envoy_admin_local_port: 15000 | ||
| gateway_api_classes: [] | ||
| # default ingress_gateway_namespace is undefined |
There was a problem hiding this comment.
It isn't true that it is undefined - the default (as created by the operator) is empty string as you have in the new PR here. So what you have here is the literal default (the defaults we are defining here in this file are the defaults assigned to the server by the operator)
Do not modify this file though
Added new configs for gateway namespaces.
Core PR kiali/kiali#7548