Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention system namespace filtering #812

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Aug 30, 2024

Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it but I think it would better if you address my comment.


{{% alert color="info" %}}
An empty list of discovery selectors has different semantics depending on the value of `deployment.cluster_wide_access`.
* If `deployment.cluster_wide_access` is `true`, an empty list of discovery selectors means all namespaces will be visible except those that are considered system namespaces (these include namespaces whose names are prefixed with "kube-", "openshift" or "ibm" such as `kube-system`, `openshift-operators`, and `ibm-system`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just make this an explicit list like before? Just show the list of regex?

Copy link
Contributor Author

@jmazzitelli jmazzitelli Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really didn't want to go so technical as to show the go-regex, since it might confuse people.

The regex, as defined here, is: ^(kube-.*|openshift.*|ibm.*|kiali-operator|istio-operator)

It requires people to understand what that means.

@jmazzitelli jmazzitelli merged commit 3c5719b into kiali:staging Aug 30, 2024
5 checks passed
@jmazzitelli jmazzitelli deleted the 7687-system-namespace-filter branch August 30, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants