Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usernames can be referred to in secrets, as well as custom dashboard credentials #825

Merged
merged 1 commit into from
Oct 7, 2024
Merged

usernames can be referred to in secrets, as well as custom dashboard credentials #825

merged 1 commit into from
Oct 7, 2024

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Oct 4, 2024 •
edited
Loading

@jmazzitelli jmazzitelli self-assigned this Oct 4, 2024
@jmazzitelli jmazzitelli mentioned this pull request Oct 4, 2024
Closed
@jshaughn jshaughn self-requested a review October 7, 2024 17:16
jshaughn
jshaughn approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@jshaughn jshaughn merged commit 362084c into kiali:staging Oct 7, 2024
5 checks passed
@jmazzitelli jmazzitelli deleted the 7795-secret-creds branch October 12, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
None yet
Projects
Kiali Sprint 25-02 | Kiali v2.5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmazzitelli @jshaughn