Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ambient content #841

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Update Ambient content #841

merged 7 commits into from
Dec 20, 2024
+38 −1

Conversation

josunect
Copy link
Contributor

@josunect josunect commented Dec 20, 2024 •
edited
Loading

@josunect josunect self-assigned this Dec 20, 2024
@josunect josunect requested a review from jshaughn December 20, 2024 11:24
@josunect josunect added the enhancement New feature or request label Dec 20, 2024
jshaughn
jshaughn reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content is great, just a couple of suggested edits.

content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
josunect and others added 6 commits December 20, 2024 16:48
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
9f9753e 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
7387f01 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
8ec01b8 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
90ea374 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
da00cc8 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
29c1d24 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
jshaughn
jshaughn approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@jshaughn jshaughn merged commit 36f14b7 into kiali:staging Dec 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@josunect josunect

Labels
enhancement New feature or request
Projects
Kiali Sprint 25-01 | Kiali v2.4
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josunect @jshaughn