need ossmconsole CRD even for non-openshift environs

[jmazzitelli]

This is happening in master builds - not affecting any releases (yet - it will affect the next release when the operator handles ossmc installs).

I was hoping we did not have to install the OSSMConsole CRD on non-OpenShift environments, but right now there isn't a way. The operator watches.yaml declares to the operator it should watch for OSSMConsole CRs. So if the CRD does not exist (and it won't if you install the Operator using OLM - the upstream OLM metadata doesn't include the CRD - only the Kiali CRD exists) then this error will occur and the operator exits:

{"level":"error","ts":"2023-10-26T23:57:33Z","logger":"controller-runtime.source","msg":
"if kind is a CRD, it should be installed before calling Start","kind":"OSSMConsole.kiali.io",
"error":"no matches for kind \"OSSMConsole\" in version \"kiali.io/v1alpha1\"","stacktrace":
...
{"level":"error","ts":"2023-10-27T00:05:14Z","logger":"cmd","msg":"Proxy or operator exited with error.","Namespace":"","error":"failed to wait for ossmconsole-controller caches to sync: timed out waiting for cache to be synced"
...

We need to add the CRD to the upstream metadata so this error is avoided. The operator helm chart includes this OSSMConsole CRD already, so that isn't an issue when helm installed

In the future it would be nice to not have the operator require this CRD to be installed on non-OpenShift environments, but I don't know how to make the watches.yaml declare to the operator that it is OPTIONAL.

[jmazzitelli]

These are the replication steps that I used to see the issue.

1. Start up minikube (you don't need Istio for this test). You can do this via the hack scripts:

hack/k8s-minikube.sh start

3. Use this one command to (1) install OLM into the cluster, (2) build the operator image, (3) push the operator image into the cluster, and (4) deploy the operator via OLM:

make -e CLUSTER_TYPE=minikube -e OLM_BUNDLE_PACKAGE=kiali -e OC=$(which kubectl) olm-install cluster-push-operator olm-operator-create

4. Eventually the error appears and the operator will stop (and restart)

[jmazzitelli]

The solution to this was redone via this issue and its PR (essentially, the OSSMConsole CRD will not be installed on non-OpenShift environments).