Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-cluster setup - no need for script to show only specific templates - the helm chart has a flag for this now #7883

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

jmazzitelli
Copy link
Collaborator

part of: #7861

nrfox
nrfox previously approved these changes Nov 7, 2024
@jmazzitelli
Copy link
Collaborator Author

@nrfox I think I need to update the script... if on OpenShift, we need it to pass --set isOpenShift=true to the helm template command.

@nrfox
Copy link
Contributor

nrfox commented Nov 7, 2024

@jmazzitelli won't it default to autodiscover?

@jmazzitelli
Copy link
Collaborator Author

@jmazzitelli won't it default to autodiscover?

No, "helm template" doesn't process .Capabilities - it always returns false. Those .Capabilities expressions are always evaluated by "helm install" (NOT "helm template").

And this script uses "helm template"

@jmazzitelli jmazzitelli merged commit b1cbee1 into kiali:master Nov 7, 2024
10 checks passed
@jmazzitelli jmazzitelli deleted the 7861-remote-cluster-resources branch November 7, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants