-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES 2.0 compatibility for 4.1.2 #10
ES 2.0 compatibility for 4.1.2 #10
Conversation
CC @reviewbybees. Current status - work-in-progress |
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
The changes make sense. I can tag this as a new version for people to download. |
ES 2.0 compatibility for 4.1.2
Can I ask about 20617b9 ? It conflicts with an internal patch I have to support rest.action.multi.allow_explicit_index: false Is there something that requires the promises here? I see the fix for no indices, but beyond that, is the conversion to promises necessary? It looks like they all resolve statically. Thanks! |
IIRC it was required to patch this method, because there were failures in ES2.0. So I've taken the method from the latest Kibana version. It worked. I do not recall if the issue was related to Promises |
I'm running with 2.0, with the old code, but I don't know if there's something that will bite me later on, if I don't change it. I've run through "Getting Started with Kibana" with no problems. If you happen to recall what the issue was, I'd appreciate the info. |
@Asimov4 @oleg-nenashev I need the version which is not bundled,could anybody help? thx |
@rayenyang WDYM? |
@oleg-nenashev I am sorry that I did not express my problem properly! In other words, I need this version you contributed,but not a big file of index.js |
This pull-request integrate changes, which allow running kibana-static against Elasticsearch 2.0. This pull request makes the Kibana instance operational on the dashboards we had.
@Asimov4 Would be such partial fix an applicable solution for kibana-static? Due to the major repo changes in 4.2..4.4, it will be hard to integrate the new data structure. I've started this activity, but there is no ETA. From what I see, kibana-4.1.2 has not been migrated completely as well.