Fix MetadataFiller to set producedBy as the service producing the msg (…

…#180)
kibertoad · Jun 30, 2024 · 243c705 · 243c705
1 parent 9dec768
commit 243c705
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/core/lib/messages/MetadataFiller.spec.ts b/packages/core/lib/messages/MetadataFiller.spec.ts
@@ -45,7 +45,6 @@ describe('MetadataFiller', () => {
       // Given
       const providedMetadata = {
         schemaVersion: '2.0.0',
-        producedBy: 'producer',
         originatedFrom: 'source',
         correlationId: 'myCorrelationId',
       }
@@ -54,7 +53,7 @@ describe('MetadataFiller', () => {
       const metadata = filler.produceMetadata(TEST_MESSAGE, EVENT_DEFINITION, providedMetadata)
 
       // Then
-      expect(metadata).toEqual(providedMetadata)
+      expect(metadata).toEqual({ ...providedMetadata, producedBy: SERVICE_ID })
     })
   })
 })
diff --git a/packages/core/lib/messages/MetadataFiller.ts b/packages/core/lib/messages/MetadataFiller.ts
@@ -49,10 +49,10 @@ export class CommonMetadataFiller implements MetadataFiller {
   produceMetadata(
     _currentMessage: PublisherBaseEventType,
     eventDefinition: Pick<CommonEventDefinition, 'schemaVersion'>,
-    precedingMessageMetadata?: MessageMetadataType,
+    precedingMessageMetadata?: Omit<MessageMetadataType, 'producedBy'>,
   ): MessageMetadataType {
     return {
-      producedBy: precedingMessageMetadata?.producedBy ?? this.serviceId,
+      producedBy: this.serviceId,
       originatedFrom: precedingMessageMetadata?.originatedFrom ?? this.serviceId,
       schemaVersion:
         precedingMessageMetadata?.schemaVersion ??