MBL-1673 [Android 15] Update Views to be compatible with edge to edge enforcement #2131
Conversation
- Created utility to manage edge to edge on different screens - fixed composable screens - fixed other screens with the utility
- Manage edge to edge behavior for all the screens - modify solution
app/build.gradle
Outdated
| @@ -52,10 +52,10 @@ if (file('signing.gradle').exists()) { | |||
|
|
|||
| android { | |||
| defaultConfig { | |||
| compileSdk 34 | |||
| compileSdkPreview = "VanillaIceCream" | |||
There was a problem hiding this comment.
Could you use API level rather than the name? aka: 35
jlplks
changed the base branch from
master
to
feat/jpulido/MBL-1739/Android-15
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feat/jpulido/MBL-1739/Android-15 #2131 +/- ##
======================================================================
- Coverage 67.78% 67.66% -0.13%
Complexity 2226 2226
======================================================================
Files 368 369 +1
Lines 22851 22903 +52
Branches 3280 3280
======================================================================
+ Hits 15490 15497 +7
- Misses 5597 5642 +45
Partials 1764 1764 ☔ View full report in Codecov by Sentry. |
|
Tested a bunch of the screens i pointed out in the ticket as having issues with edge to edge on the branch and I still see the issues. Many of the top bars cant be interacted with now as they are behind the notification bar |
|
In what device are you testing, @mtgriego ? I test on an emulator targeting Android 15 and it works EMULATOR SPECTS SCREENS ON EMULATOR |
📲 What
Modify all the screens to be compatible with Android edge to edge.
🤔 Why
Android 15 introduced edge to edge view enforcement for apps targeting the version (sdk 35). We need to update some views to look normal in this new context.
🛠 How
For the screens that use composable fixed with
Modifier.systemBarsPadding(),For the others screens a utility was created
WindowInsetsUtilStory 📖
[Android 15] Update Views to be compatible with edge to edge enforcement