Skip to content

Commit

Permalink
Address comments from review #1939
Browse files Browse the repository at this point in the history
  • Loading branch information
amy-at-kickstarter committed Feb 12, 2024
1 parent 73b2860 commit a4fdd05
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ private struct PaginationExampleProjectList: View {
Spacer()
}
.padding(EdgeInsets(top: 20, leading: 0, bottom: 20, trailing: 0))
.background(Color.yellow)
.background(.yellow)
List {
ForEach(projectIdsAndTitles, id: \.0) {
let title = $0.1
PaginationExampleProjectCell(title: $0.1)
PaginationExampleProjectCell(title: title)
}
if showProgressView {
HStack {
Expand All @@ -39,7 +39,7 @@ private struct PaginationExampleProjectList: View {
}
Spacer()
}
.background(Color.yellow)
.background(.yellow)
}
}
.refreshable {
Expand Down
4 changes: 1 addition & 3 deletions Library/Paginator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,7 @@ public class Paginator<Envelope, Value: Equatable, Cursor, SomeError: Error, Req
self?.isLoading = false
})
.sink(receiveValue: { [weak self] envelope in
guard let self = self else {
return
}
guard let self else { return }

let newValues = self.valuesFromEnvelope(envelope)
self.values.append(contentsOf: newValues)
Expand Down

0 comments on commit a4fdd05

Please sign in to comment.