-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[WEB-696] CTA Dialog on Facebook Login Error (FB Deprecation) (#1763)
* create SetYourPasswordViewController and SetYourPasswordViewModel * alphabetize SetYourPasswordViewModel & ViewModelTests files * adds viewmodel tests * add viewcontroller tests * present new CTA on facebook login error * remove TODO comment * remove snapshot tests until they can be recorded on an intel machine
- Loading branch information
1 parent
b936c69
commit cd6fe2b
Showing
16 changed files
with
591 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
251 changes: 251 additions & 0 deletions
251
...atures/ResetYourFacebookPassword/Controller/ResetYourFacebookPasswordViewController.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,251 @@ | ||
| import Foundation | ||
| import Library | ||
| import Prelude | ||
| import ReactiveSwift | ||
| import UIKit | ||
|
|
||
| public final class ResetYourFacebookPasswordViewController: UIViewController { | ||
| // MARK: - Properties | ||
|
|
||
| private lazy var contextLabel = { UILabel(frame: .zero) }() | ||
| private lazy var emailLabel: UILabel = { UILabel(frame: .zero) }() | ||
| private lazy var emailTextField: UITextField = { UITextField(frame: .zero) |> \.tag .~ 0 }() | ||
|
|
||
| private lazy var loadingIndicator: UIActivityIndicatorView = { | ||
| UIActivityIndicatorView() | ||
| |> \.translatesAutoresizingMaskIntoConstraints .~ false | ||
| }() | ||
|
|
||
| private lazy var rootStackView = { UIStackView() }() | ||
| private lazy var scrollView = { | ||
| UIScrollView(frame: .zero) | ||
| |> \.alwaysBounceVertical .~ true | ||
|
|
||
| }() | ||
|
|
||
| private lazy var setPasswordButton = { UIButton(type: .custom) | ||
| |> \.translatesAutoresizingMaskIntoConstraints .~ false | ||
| }() | ||
|
|
||
| fileprivate lazy var keyboardDimissingTapGestureRecognizer: UITapGestureRecognizer = { | ||
| UITapGestureRecognizer( | ||
| target: self, | ||
| action: #selector(ResetYourFacebookPasswordViewController.dismissKeyboard) | ||
| ) | ||
| |> \.cancelsTouchesInView .~ false | ||
| }() | ||
|
|
||
| private let viewModel: ResetYourFacebookPasswordViewModelType = ResetYourFacebookPasswordViewModel() | ||
|
|
||
| // MARK: - Lifecycle | ||
|
|
||
| public override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
|
|
||
| self.title = "Set new password" | ||
|
|
||
| self.view.addGestureRecognizer(self.keyboardDimissingTapGestureRecognizer) | ||
|
|
||
| self.configureViews() | ||
| self.setupConstraints() | ||
| self.configureTargets() | ||
|
|
||
| self.viewModel.inputs.viewDidLoad() | ||
| } | ||
|
|
||
| public override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
|
|
||
| self.viewModel.inputs.viewWillAppear() | ||
| } | ||
|
|
||
| // MARK: - Styles | ||
|
|
||
| public override func bindStyles() { | ||
| super.bindStyles() | ||
|
|
||
| _ = self.contextLabel | ||
| |> contextLabelStyle | ||
|
|
||
| _ = self.rootStackView | ||
| |> baseStackViewStyle | ||
| |> loginRootStackViewStyle | ||
|
|
||
| _ = self.emailLabel | ||
| |> textFieldLabelStyle | ||
|
|
||
| _ = self.emailTextField | ||
| |> emailFieldStyle | ||
| |> roundedStyle(cornerRadius: Styles.grid(2)) | ||
| |> \.borderStyle .~ UITextField.BorderStyle.roundedRect | ||
| |> \.layer.borderColor .~ UIColor.ksr_support_300.cgColor | ||
| |> \.layer.borderWidth .~ 1 | ||
| |> \.accessibilityLabel .~ self.emailLabel.text | ||
| |> \.attributedPlaceholder %~ { _ in settingsAttributedPlaceholder("") } | ||
|
|
||
| _ = self.setPasswordButton | ||
| |> resetPasswordButtonStyle | ||
| |> UIButton.lens.title(for: .normal) %~ { _ in | ||
| Strings.Set_new_password() | ||
| } | ||
| |> \.isEnabled .~ false | ||
| } | ||
|
|
||
| // MARK: - Bind View Model | ||
|
|
||
| public override func bindViewModel() { | ||
| super.bindViewModel() | ||
|
|
||
| self.loadingIndicator.rac.animating = self.viewModel.outputs.shouldShowActivityIndicator | ||
| self.contextLabel.rac.text = self.viewModel.outputs.contextLabelText | ||
| self.emailLabel.rac.text = self.viewModel.outputs.emailLabel | ||
| self.setPasswordButton.rac.enabled = self.viewModel.outputs.setPasswordButtonIsEnabled | ||
|
|
||
| self.viewModel.outputs.setPasswordFailure | ||
| .observeForControllerAction() | ||
| .observeValues { [weak self] errorMessage in | ||
| self?.present(UIAlertController.genericError(errorMessage), animated: true, completion: nil) | ||
| self?.enableTextFieldsAndSaveButton(true) | ||
| } | ||
|
|
||
| self.viewModel.outputs.setPasswordSuccess | ||
| .observeForControllerAction() | ||
| .observeValues { [weak self] successMessage in | ||
| self?.present(UIAlertController.alert(message: successMessage), animated: true) | ||
| self?.enableTextFieldsAndSaveButton(true) | ||
| } | ||
|
|
||
| self.viewModel.outputs.textFieldAndSetPasswordButtonAreEnabled | ||
| .observeForUI() | ||
| .observeValues { [weak self] isEnabled in | ||
| self?.enableTextFieldsAndSaveButton(isEnabled) | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Functions | ||
|
|
||
| private func configureViews() { | ||
| _ = self.view | ||
| |> \.backgroundColor .~ .ksr_white | ||
|
|
||
| _ = (self.scrollView, self.view) | ||
| |> ksr_addSubviewToParent() | ||
| |> ksr_constrainViewToEdgesInParent() | ||
|
|
||
| _ = (self.rootStackView, self.scrollView) | ||
| |> ksr_addSubviewToParent() | ||
| |> ksr_constrainViewToEdgesInParent() | ||
|
|
||
| _ = ([ | ||
| self.contextLabel, | ||
| self.emailLabel, | ||
| self.emailTextField, | ||
| self.setPasswordButton, | ||
| self.loadingIndicator | ||
| ], self.rootStackView) | ||
| |> ksr_addArrangedSubviewsToStackView() | ||
|
|
||
| self.rootStackView.setCustomSpacing(Styles.grid(7), after: self.contextLabel) | ||
| } | ||
|
|
||
| private func setupConstraints() { | ||
| NSLayoutConstraint.activate([ | ||
| self.rootStackView.widthAnchor.constraint(equalTo: self.view.widthAnchor), | ||
|
|
||
| self.emailTextField.heightAnchor.constraint(greaterThanOrEqualToConstant: 44), | ||
|
|
||
| self.setPasswordButton.heightAnchor.constraint(greaterThanOrEqualToConstant: 48) | ||
| ]) | ||
| } | ||
|
|
||
| private func configureTargets() { | ||
| self.emailTextField | ||
| .addTarget(self, action: #selector(self.textFieldDidChange(_:)), for: .editingChanged) | ||
| self.setPasswordButton | ||
| .addTarget(self, action: #selector(self.setPasswordButtonPressed), for: .touchUpInside) | ||
| } | ||
|
|
||
| private func enableTextFieldsAndSaveButton(_ isEnabled: Bool) { | ||
| _ = [self.emailTextField, self.setPasswordButton] | ||
| ||> \.isUserInteractionEnabled .~ isEnabled | ||
|
|
||
| self.setPasswordButton.isHidden = !isEnabled | ||
| } | ||
|
|
||
| // MARK: - Accessors | ||
|
|
||
| @objc private func dismissKeyboard() { | ||
| self.view.endEditing(true) | ||
| } | ||
|
|
||
| @objc private func textFieldDidChange(_ textField: UITextField) { | ||
| guard let email = textField.text else { return } | ||
|
|
||
| self.viewModel.inputs.emailTextFieldFieldDidChange(email) | ||
| } | ||
|
|
||
| @objc private func setPasswordButtonPressed() { | ||
| self.viewModel.inputs.setPasswordButtonPressed() | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Extensions | ||
|
|
||
| extension ResetYourFacebookPasswordViewController: UITextFieldDelegate { | ||
| public func textFieldDidEndEditing(_ textField: UITextField) { | ||
| guard let email = textField.text else { return } | ||
|
|
||
| self.viewModel.inputs.emailTextFieldDidReturn(email: email) | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Styles | ||
|
|
||
| private let baseStackViewStyle: StackViewStyle = { stackView in | ||
| stackView | ||
| |> \.distribution .~ .fill | ||
| |> \.alignment .~ .fill | ||
| |> \.axis .~ .vertical | ||
| |> UIStackView.lens.spacing .~ Styles.grid(2) | ||
| } | ||
|
|
||
| private let contextLabelStyle: LabelStyle = { label in | ||
| label | ||
| |> \.textAlignment .~ NSTextAlignment.left | ||
| |> \.lineBreakMode .~ NSLineBreakMode.byWordWrapping | ||
| |> \.numberOfLines .~ 0 | ||
| |> UILabel.lens.font %~ { _ in UIFont.ksr_body(size: 16) } | ||
| } | ||
|
|
||
| private let textFieldLabelStyle: LabelStyle = { label in | ||
| label | ||
| |> \.textAlignment .~ NSTextAlignment.left | ||
| |> \.lineBreakMode .~ NSLineBreakMode.byWordWrapping | ||
| |> \.numberOfLines .~ 0 | ||
| |> \.backgroundColor .~ .ksr_white | ||
| |> \.textColor .~ UIColor.ksr_support_700 | ||
| |> \.font %~ { _ in .ksr_callout(size: 13) } | ||
| } | ||
|
|
||
| private let textFieldStyle: TextFieldStyle = { textField in | ||
| textField | ||
| |> settingsNewPasswordFormFieldAutoFillStyle | ||
| |> roundedStyle(cornerRadius: Styles.grid(2)) | ||
| |> UITextField.lens.textColor .~ .ksr_black | ||
| |> UITextField.lens.font %~ { _ in UIFont.ksr_body(size: 13) } | ||
| |> \.textAlignment .~ .left | ||
| |> \.borderStyle .~ UITextField.BorderStyle.roundedRect | ||
| |> \.layer.borderColor .~ UIColor.ksr_support_300.cgColor | ||
| |> \.layer.borderWidth .~ 1 | ||
| |> \.returnKeyType .~ .done | ||
| } | ||
|
|
||
| private let savePasswordButtonStyle: ButtonStyle = { button in | ||
| button | ||
| |> greenButtonStyle | ||
| |> roundedStyle(cornerRadius: Styles.grid(2)) | ||
| |> UIButton.lens.backgroundColor(for: .disabled) .~ UIColor.ksr_support_300.mixLighter(0.12) | ||
| |> UIButton.lens.title(for: .normal) %~ { _ in | ||
| Strings.Save() | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.