Feature Optimizely #1008
Merged
Feature Optimizely #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip - optimizely ab test set up * wip - optimizely struct * wip - optimizely * wip - optimizely refactor * wip - optimizely * wip - a testable optimizely client * wip - a testable optimizely client swift format * wip - optimixely refactor * wip - optimizely fix tests * wip - optimizely appdelegate test * wip - optimizely fix * wip - optimizely test environment * wip - optimizely * wip - remove func * [NT-580] Optimizely Integration Updates (#999) * Testing configuration result * Linking Optimizely with Framework instead of main app target * Updating targets * Cleaning up targets etc * Removing commented out line * Formatting * Remove test code * Line length * Add OptimizelyResultType with tests * Formatting and adding weak self * Line length * Chaining the variant enum into the guard Co-authored-by: Isabel Barrera <ifbarrera@me.com>
* wip - optimizely ab test set up * wip - optimizely struct * wip - optimizely * wip - optimizely refactor * wip - optimizely * wip - a testable optimizely client * wip - a testable optimizely client swift format * wip - optimixely refactor * wip - optimizely fix tests * wip - optimizely appdelegate test * wip - optimizely fix * wip - optimizely test environment * wip - optimizely * wip - remove func * See rewards experimental copy * wip - optimizely a/b experiment * snapshot testing * Formatting * Fixing targets, tests * Cleaning up warnings * Removing Optimizely imports * Specify control group in VC test * Merge * MockUUID and shared function * Formatting Co-authored-by: Isabel Barrera <ifbarrera@me.com>
* Setting OptimizelyLogLevel based on bundle type * Formatting * Adding OptimizelyLogLevelType as a file
…feature-optimizely # Conflicts: # Cartfile.resolved # Kickstarter-iOS/ViewModels/AppDelegateViewModel.swift # Kickstarter-iOS/ViewModels/AppDelegateViewModelTests.swift
Generated by 🚫 Danger |
justinswart
approved these changes
Jan 7, 2020
| optimizelyClient.start { [weak self] result in | ||
| let shouldUpdateClient = self?.viewModel.inputs.optimizelyConfigured(with: result) | ||
|
|
||
| if let shouldUpdateClient = shouldUpdateClient, shouldUpdateClient { |
There was a problem hiding this comment.
This could probably just be if shouldUpdateClient == true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
A collection of PRs for the Optimizely integration and first Optimizely A/B experiment.
PRs:
#989
#994
#1007