[NT-783] Simplify internal/external link behaviour in updates #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes a bug found during UAT of #1054 and simplifies our logic around handling internal/external links for project updates.
🤔 Why
During UAT we discovered prelaunch project links were sometimes doing nothing when tapped.
🛠 How
@ifbarrera and I refactored all of the
.zipsignals to make this logic easier to understand. It seems that what was happening before is that tapping multiple links caused the.zip'd signals to emit in an unexpected manner. By changing these signals to determine whether the URL being tapped is internal/external early on and then carrying the navigation action through the chain we were able to correct this.✅ Acceptance criteria
SFSafariViewController.SFSafariViewController.