Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NT-1167] Update category selection "Continue" button style #1166

Merged
merged 3 commits into from
Apr 21, 2020
Merged

[NT-1167] Update category selection "Continue" button style #1166

merged 3 commits into from
Apr 21, 2020

Conversation

ifbarrera
Copy link
Contributor

📲 What

Updates the style of the "Continue" button on the category selection screen.

🤔 Why

We decided that the greyButtonStyle looked too disabled (even when it was enabled), so we switched it to greenButtonStyle.

🛠 How

  • update the button style to greenButtonStyle
  • regenerate the screenshot tests for CategorySelectionViewController

👀 See

lVN2nwQ1h7

✅ Acceptance criteria

  • Navigate to the category selection screen. The "Continue" button should be light green when disabled, and solid green when enabled

@ifbarrera ifbarrera merged commit 1b16c32 into master Apr 21, 2020
@ifbarrera ifbarrera deleted the NT-1167-categories-button-style branch April 21, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsamudio jgsamudio jgsamudio approved these changes

Assignees

@jgsamudio jgsamudio

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifbarrera @jgsamudio