-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-1203] Lights On Editorial Collection #1197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * new copy * new snapshots * swift format * remove old code * corrected test * translated copy * reused cell * swift format * pr feedback * smapshot tests * correct image
…ub.com/kickstarter/ios-oss into NT-1203-lights-on-editorial-collection
…1194) * wip * new copy * new snapshots * swift format * remove old code * corrected test * new copy * translated copy * reused cell * swift format * wip * wip * pr feedback * smapshot tests * snapshots * delete file * removed copy * missing copy * snapshots * swift format * changed tag id * sorted by distance * test refactor * fix test * Tidy up * Fix icon * Snapshots Co-authored-by: Justin Swart <justinswart@users.noreply.github.com>
Generated by 🚫 Danger |
* Add Optimizely lights on feature flag, remove Go Rewardless references * Snapshots * Formatting * Remove extra underscore * Remove table view header, fix typo, update snapshots * Oops
# Conflicts: # Library/ViewModels/DiscoveryPageViewModelTests.swift
* Add Optimizely lights on feature flag, remove Go Rewardless references * Snapshots * Formatting * Remove extra underscore * Remove table view header, fix typo, update snapshots * Oops * Update copy * Fix tests * Fix layout
ifbarrera
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Lights On Editorial Collection Feature. Includes the following PRs:
#1185, #1194, #1196, #1208
👀 See