Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1315] Native Project Cards Design Tweaks #1219

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Jun 9, 2020

📲 What

A couple design tweaks and small bug fixes for the Native Project Cards experiment.

🤔 Why

Final cleanup in preparation to release this experiment.

🛠 How

  • fixes a bug where large numbers in the backers count label were not being properly formatted
  • fixes a bug where the "Save" button wasn't working properly because not all the outputs were hooked up to the view model
  • adds a shadow to the project status tag and the "Save" button to improve contrast against light backgrounds
  • decreases the top and bottom margins on the project status tag view

👀 See

Trello, screenshots, external resources?

After 🦋 Before 🐛
Simulator Screen Shot - after Simulator Screen Shot - before

✅ Acceptance criteria

Whitelist your device into the native_project_cards experiment.

  • Run the app. Find a project with a large number of backers. The backer count should appear larger than the backers text, and should be bolded
  • Saving and un-saving projects in discovery should work as expected, and should generate feedback when run on a device
  • The project status tag view and the save button should have a very subtle shadow

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ifbarrera ifbarrera merged commit 20e5442 into master Jun 9, 2020
@ifbarrera ifbarrera deleted the NT-1315-design-tweaks branch June 9, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants