[NT-1493] Hide Shipping in Manage View Based on Base Reward #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Hides the shipping line item displayed on the Manage Pledge View based on the base reward's shipping preference.
🤔 Why
When editing a reward from one that has shipping to one without the back-end erroneously sends back shipping information for the backing which we were displaying at the client. This is a workaround to prevent that from happening.
🛠 How
We are now inspecting whether shipping is enabled for the backing's base reward before displaying the shipping line item.
👀 See
✅ Acceptance criteria