Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1524] Add German, Spanish and Japanese translations to copy #1302

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

singhhari
Copy link
Contributor

…ons.

📲 What

Update snapshot tests and strings files to include languages that were not ready for translation in the original PR.

🤔 Why

The translations for German, Spanish and Japanese were not included in the original PR.

🛠 How

Re-ran make strings and recorded new snapshots.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1302   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files        1108     1108           
  Lines       96766    96766           
=======================================
  Hits        82915    82915           
  Misses      13851    13851           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f145d92...8915a56. Read the comment docs.

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@singhhari singhhari merged commit bd75f3c into master Sep 23, 2020
@singhhari singhhari deleted the NT-1524-update-backed-reward-copy-languages branch September 23, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants