[NT-1499] Xcode 12/iOS 14.0 Compatibility #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_de_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_de_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_de_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_es_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_es_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_es_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_ja_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_ja_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_Backer_LiveProject_Landscape_lang_ja_device_phone5_8inch@2x.png
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
=======================================
Coverage 85.68% 85.69%
=======================================
Files 1108 1108
Lines 96766 96780 +14
=======================================
+ Hits 82915 82935 +20
+ Misses 13851 13845 -6
Continue to review full report at Codecov.
|
justinswart
commented
Sep 24, 2020
| .map { $0 && $1 } | ||
| .map { isEmailVerified, isEmailDeliverable -> Bool in | ||
| let r = isEmailVerified && isEmailDeliverable | ||
| return r |
There was a problem hiding this comment.
These changes are kind've unfortunate and seem unnecessary but I wasn't able to get this code to compile without introducing some of these local scope vars.
| @@ -95,7 +95,7 @@ public final class CommentsViewModel: CommentsViewModelType, CommentsViewModelIn | |||
| self.viewDidLoadProperty.signal, | |||
| self.userSessionStartedProperty.signal | |||
| ) | |||
| .map { AppEnvironment.current.currentUser } | |||
| .map { _ in AppEnvironment.current.currentUser } | |||
There was a problem hiding this comment.
This works around the Swift function overload bug.
| generateStandardViewControllers() | ||
| } | ||
| let personalizedViewControllers = userState.map { userState -> [RootViewControllerData] in | ||
| generatePersonalizedViewControllers(userState: (userState.isMember, userState.isLoggedIn)) |
There was a problem hiding this comment.
This was necessary to work around something that was deprecated in Swift called tuple shuffling: https://noahgilmore.com/blog/tuple-shuffling/
justinswart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updates our codebase for compatibility with Xcode 12.0 and builds the app against the iOS 14.0 SDK.
🤔 Why
Always good to keep things up to date, Xcode 12.0, Swift 5.3 and iOS 14.0 all bring improvements that we would like to have access to in our workflow.
🛠 How
✅ Acceptance criteria