-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADHOCREQ-106] Redirect to safari for braze links that aren't deep links #1845
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1845 +/- ##
=======================================
Coverage 84.54% 84.54%
=======================================
Files 1272 1272
Lines 115364 115378 +14
Branches 30710 30710
=======================================
+ Hits 97530 97542 +12
- Misses 16765 16767 +2
Partials 1069 1069
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea great quick fix.
Just for future, small organizational things - include the milestone in this PR |
Added the milestone - I didn't do this initially, since I wasn't sure what release this would land in. I didn't think we have a ticket for this, but I guess you're counting ADHOCREQ-106. I'll link it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
tested by following our deep-linking guru cards
📲 What
We currently try to parse all braze links as deep links. This is a simple change that looks at the link itself to determine if it's a deep link or not. Deep links are handled the same as before; other links will now open in Safari instead of doing nothing.
Note that this does not try to parse the braze info to see if the link was intended to be opened in web or not.
🤔 Why
External links from braze notifications are currently broken; nothing happens if the user tries to click on them.
👀 See
JIRA bug
RPReplay-Final1692715886.mov
✅ Acceptance criteria
⏰ TODO