-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-982] Support Project Fragment's Flagging Property #1855
Conversation
… the flagging field
…a project has been flagged by the user previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but check there aren't tests we can write for this new property (noted below).
KsApi/models/graphql/adapters/Project+FetchProjectQueryData.swift
Outdated
Show resolved
Hide resolved
a996642
to
63012ba
Compare
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## main #1855 +/- ##
=======================================
Coverage 84.06% 84.06%
=======================================
Files 1280 1280
Lines 116796 116823 +27
Branches 31035 31043 +8
=======================================
+ Hits 98180 98207 +27
+ Misses 17533 17532 -1
- Partials 1083 1084 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📲 What
Adds support for the GraphQL field:
Also adds an output signal to
ProjectPageViewModel
that we can use in the ProjectPageViewController when we're ready.🤔 Why
This new property will help tell us if a user has already flagged a project. Allowing us to keep them from reporting again.
🛠 How
Added this property to the
FetchProjectById
&FetchProjectBySlug
fragments.Rather than add this to the base fetchproject query, we can add it only to these sub queries so that we only access this property as needed.
✅ Acceptance criteria