[MBL-1076] Fix v1 user #1902
Merged
[MBL-1076] Fix v1 user #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,8 +198,14 @@ final class CommentRepliesViewController: UITableViewController, MessageBannerVi | |||
| } | |||
|
|
|||
| private func handleCommentCellHeaderTapped(in cell: UITableViewCell, _ author: Comment.Author) { | |||
| guard AppEnvironment.current.currentUser != nil, featureBlockUsersEnabled() else { return } | |||
| guard author.isBlocked == false else { return } | |||
| guard | |||
There was a problem hiding this comment.
This could probably be in a helper func somewhere, it's getting a little long!
There was a problem hiding this comment.
Yeah, I thought about that but I didn't see a nice place to put it. I'm going to just leave this for now so we can move forward with this, but I'll look into/see if Scott has ideas for where this kind of helper code should live.
amy-at-kickstarter
approved these changes
Dec 7, 2023
scottkicks
approved these changes
Dec 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1902 +/- ##
==========================================
- Coverage 83.73% 83.72% -0.02%
==========================================
Files 1226 1226
Lines 111776 111788 +12
Branches 29725 29723 -2
==========================================
- Hits 93598 93596 -2
- Misses 17161 17175 +14
Partials 1017 1017 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
The backend field is
isBlockednotis_blocked. This also stops users from blocking themselves.👀 See
Jira
✅ Acceptance criteria