[MBL-1143] Delete ProjectDescriptionViewController #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ifosli
force-pushed
the
ProjectDescriptionVCCleanup
branch
from
978fc54 to
f4c18c5
Compare
ifosli
force-pushed
the
ProjectDescriptionVCCleanup
branch
from
f4c18c5 to
40b3bf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
- Coverage 83.75% 83.74% -0.01%
==========================================
Files 1223 1220 -3
Lines 111811 111299 -512
Branches 29750 29610 -140
==========================================
- Hits 93642 93206 -436
+ Misses 17147 17074 -73
+ Partials 1022 1019 -3 ☔ View full report in Codecov by Sentry. |
scottkicks
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
The ProjectDescriptionViewController is one of our old web views - it's no longer needed now that the project page has a campaign tab. In order to delete the class, old references to it are removed and surrounding code cleaned up
Note that this pr is probably easiest to review commit by commit - each commit stands alone and it makes it easier to keep track of changes. Also, the screenshots look identical but are just different enough that they needed to be re-recorded.
The project faq deeplink will now simply open the project page.
👀 See
JIRA
✅ Acceptance criteria