[MBL-1175] CreateCheckout & CreatePaymentIntent Mutations #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
amy-at-kickstarter
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
These changes LGTM, but are the extra adapters for input and output envelopes necessary? The GraphQL objects are very small, and they appear to map 1:1 to your envelopes and your input adapters. It seems like you could just use the GraphQL objects directly and save a bunch of extra code and tests to maintain.
My understanding is that the adapter/envelope mapping pattern is only if a GraphQL object needs to map to an API V1 object for compatibility reasons.
scottkicks
deleted the
scott/feat/latepledge/checkout-and-paymentintent-mutations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
For the upcoming Post Campaign Pledging work, we're going to be implementing 4 new mutations,
CreateCheckoutCreatePaymentIntent,ValidateCheckout, andCreateBackingOnSessionI'll add PRs to support these as the backend implements them. This PR adds support for
CreateCheckoutandCreatePaymentIntent.🤔 Why
For more context around what these mutations will be used for and why we need them give this a read: https://kickstarter.atlassian.net/wiki/spaces/PAYM/pages/2586443778/Validations+Approach+1+Separate+validations+from+Checkouts+Apply+service+client-side+confirmation#Mobile-proposal
🛠 How
More in-depth discussion of the change or implementation.
👀 See
No UI changes