[MBL-1315] Move save button styling off prelude #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
approved these changes
Apr 9, 2024
amy-at-kickstarter
added a commit
that referenced
this pull request
Apr 16, 2024
This reverts commit 8e8f683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Neither Scott nor I have been able to reproduce this crash. However, according to the crash logs, it's happening when the
DiscoveryPostcardCell's save button's accessibility label is set using prelude. I'm not sure if this change will actually fix the crash, but hopefully if it doesn't, it'll get us more info.Note: if prelude accessibility labels + iPads + iOS 17.4 is actually the problem, we should start seeing this crash other places in our codebase once this version of it is fixed. If that happens, we'll at least know how to fix it going forward.
👀 See
Jira
✅ Acceptance criteria