Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1376] Make users in tests look fake #2064

Merged
merged 9 commits into from
May 22, 2024
Merged

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented May 21, 2024

📲 What

Update user names, emails, and uids to be obviously fake. This updates both template files and emails used directly in test files. If you see anything else that should be updated/removed, let me know!

Note that this pr does not delete any file history.

👀 See

Jira

✅ Acceptance criteria

  • Information in tests no longer looks sensitive

⏰ TODO

(Not in this pr) I'd like to delete the file history of all these template files as well, but it's a lot of files and requires me deleting and re-adding them and force pushing to master, so it's definitely not happening in this commit.

@ifosli ifosli self-assigned this May 21, 2024
@ifosli ifosli force-pushed the makeTestEmailsLookVeryFake branch from 3b16272 to 34d1d6f Compare May 21, 2024 16:51
@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@ifosli ifosli marked this pull request as ready for review May 21, 2024 17:11
@ifosli ifosli requested review from a team and scottkicks and removed request for a team May 21, 2024 17:11
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Appreciate the clear commits!

@ifosli ifosli merged commit 86d3bf3 into main May 22, 2024
5 checks passed
@ifosli ifosli deleted the makeTestEmailsLookVeryFake branch May 22, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants