Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1457] Create empty state view for PPO #2092

Merged
merged 3 commits into from
Jul 9, 2024
Merged

[MBL-1457] Create empty state view for PPO #2092

merged 3 commits into from
Jul 9, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Jul 8, 2024

📲 What

Add an empty state view to the pledged projects overview.

Note: I didn't add a view model for the empty state view since it's so simple that I don't feel like it would add value. If anyone disagrees, however, let me know!

Note: This only kind of supports dynamic type: if the trait collection changes after the view has rendered, it doesn't re-render. The rest of our app is already pretty inconsistent about behavior when the trait collection changes, so I don't think this is worse than the current app experience. We may want to revisit this if/when we re-do the design system, though.

👀 See

Jira, figma

Screen recording Large text
Simulator Screen Recording - iPhone 15 Pro Max - 2024-07-08 at 06 50 28 Simulator Screen Recording - iPhone SE (3rd generation) - 2024-07-08 at 07 20 51

♿️ Accessibility

  • Tap targets use minimum of 44x44 pts dimensions
  • Works with VoiceOver
  • Supports Dynamic Type

✅ Acceptance criteria

  • Empty state view looks good
  • Empty state button works

(we're not testing that the empty state view shows up when it should yet)

⏰ TODO

@ifosli ifosli self-assigned this Jul 8, 2024
@ifosli ifosli marked this pull request as ready for review July 8, 2024 14:01
@ifosli ifosli requested a review from scottkicks July 8, 2024 14:01
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that a View Model for this view doesn't add enough value to warrant one. There also aren't any @State objects to manage either.

LGTM 👍 Yay SwiftUI!

@ifosli ifosli changed the title [MBL-1457] Empty state ppo [MBL-1457] Create Empty state view for PPO Jul 9, 2024
@ifosli ifosli changed the title [MBL-1457] Create Empty state view for PPO [MBL-1457] Create empty state view for PPO Jul 9, 2024
@ifosli ifosli merged commit 0113425 into main Jul 9, 2024
5 checks passed
@ifosli ifosli deleted the emptyStatePpo branch July 9, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants