Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1857] Use correct shipping location for checkout #2132

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

shubha-rajan
Copy link
Contributor

@shubha-rajan shubha-rajan commented Aug 22, 2024

📲 What

Use the location id from selectedShippingRule instead of project when calling createCheckoutInput.

🤔 Why

Some pledges in production had a shipping location set to a city or town (they should be set to a country) and that the incorrect shipping location matched the project location.

👀 See

The bug (user selected US Shipping, which is $30, no bonus support):
image
image
Jira

✅ Acceptance criteria

  • Late pledge a project on staging and select a shipping location that is different from the project location
  • Verify that the location of the created checkout and backing match the location selected in the previous step.

Copy link
Contributor

@ifosli ifosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this and fixing it!

@nativeksr
Copy link
Collaborator

SwiftFormat found issues:

File Rules
Library/ViewModels/ConfirmDetailsViewModel.swift:348:1 warning: (wrap) Wrap lines that exceed the specified maximum width.
Library/ViewModels/NoShippingConfirmDetailsViewModel.swift:289:1 warning: (wrap) Wrap lines that exceed the specified maximum width.

Generated by 🚫 Danger

@shubha-rajan shubha-rajan merged commit 2bc129f into main Aug 26, 2024
5 checks passed
@shubha-rajan shubha-rajan deleted the WEB-1857/late-pledge-shipping-bug branch August 26, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants