[NO TICKET] Rewards Load Before Shipping Locations Have Loaded #2136
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
approved these changes
Aug 29, 2024
…l be investigated as tech debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Waits for the shipping locations to finish loading to show rewards carousel.
We don't have loading states for this in the designs, so I'll be bringing this up with Alison as well.
🤔 Why
Noticed an issue where the rewards can load before the shipping location is selected.
Since the rewards should be filtered by location, we don't want users to be able to select a reward that may not be available for that location.
🛠 How
The Location Selector is already set up to make it easy to pass a Bool that tells us when it has finished loading.
This allows us to control the reward collection view's hidden state dynamically.
👀 See
✅ Acceptance criteria