[MBL-1681] Fix confirm details bonus #2146
Merged
+558
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
approved these changes
Sep 4, 2024
Generated by 🚫 Danger |
ifosli
added a commit
that referenced
this pull request
Sep 5, 2024
* Use passed in bonus support * Copy the confirm details vm tests * Update tests to make sense for the vm without shipping * Use initial bonus amount in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Use the bonus amount that's passed in to the confirm details page to initialize the stepper.
Note: This also adds tests for the no shipping confirm details vm, since these were missing. I'm skipping the "continue" button test since I think it's probably related to MBL-1687 and should be fixed as part of that work. In order to see changes to the copied test file, review commit by commit.
👀 See
Jira
✅ Acceptance criteria