Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1761] Add pledge redemption deep links #2166

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Oct 2, 2024

📲 What

Add pledge redemption deeplinks to our supported deeplinks and make the webview a little more general. I've removed the "survey" title, since this doesn't always apply, and renamed the navigation enum to surveyWebview instead of survey. I don't love that name, but it feels a little more general to me without being something that can be conflated with a native screen. Open to suggestions or feedback on the name!

Note: Since these new deeplinks are under the project path, supporting them does not require changes to our AASA files. (see ex www.kickstarter.com/apple-app-site-association)

👀 See

Jira

Before 🐛 After 🦋
image image

✅ Acceptance criteria

  • New pledge redemption deeplinks open the relevant pages (authentication and making those pages actually look good still needs to be done by team b)

⏰ TODO

  • I'll make sure I test this end to end before launch!

@ifosli ifosli self-assigned this Oct 2, 2024
@ifosli ifosli force-pushed the addPledgeRedemptionDeepLinks branch from 31eb98f to 32291df Compare October 3, 2024 15:45
@ifosli ifosli marked this pull request as ready for review October 3, 2024 16:07
@stevestreza-ksr
Copy link
Contributor

Merging this by request

@stevestreza-ksr stevestreza-ksr merged commit 34ec6a0 into main Oct 7, 2024
5 checks passed
@stevestreza-ksr stevestreza-ksr deleted the addPledgeRedemptionDeepLinks branch October 7, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants