[NT-206] Add accessibility label to the toggle #862
Conversation
|
Unfortunately I didn't have a real device to build on so please test on a real device. |
| @@ -14,5 +14,8 @@ final class ManageViewPledgeRewardReceivedViewController: ToggleViewController { | |||
|
|
|||
| _ = self.toggle | |||
| |> checkoutSwitchControlStyle | |||
| |> \.accessibilityLabel %~ { | |||
| _ in localizedString(key: "Reward_received", defaultValue: "Reward received") | |||
There was a problem hiding this comment.
Are we still waiting for translations or can we use Strings.Reward_received? 🤔
There was a problem hiding this comment.
Tried pulling new strings ... still not translated ... I thought we're not going to block PRs because of localizations but I'm happy to hold on for now
There was a problem hiding this comment.
I can't remember what we decided about localizations 😭but I think we should at least wait for the key to be available in the Strings file?
|
I believe so..I was under the impression that these are section headers (please see the attachment)
|
dusi
added
blocked
|
Waiting for base strings |
|
Made https://github.com/kickstarter/kickstarter/pull/17573 Will wait for it to be deployed and I think we should not hold a11y by localization so I'll add a TODO to my follow up PR to address localization separately |
dusi
added
needs review
and removed
blocked
|
@ifbarrera I've updated the strings (they're not localized yet)...but I think it should not hold this PR...I've also updated the ticket to include localization of reward received toggle logic in JIRA so that we can keep track of it and not sign off on it before it's localized. |
| @@ -406,6 +406,7 @@ | |||
| "Reward_Surveys.zero" = "%{reward_survey_count} questionnaires"; | |||
| "Reward_delivered" = "Récompense livrée ?"; | |||
| "Reward_estimated_for_delivery_in_date" = "<b>Récompense</b> prévue pour %{delivery_date}"; | |||
| "Reward_received" = "Récompense reçue"; | |||
There was a problem hiding this comment.
Lol, actually already translated in 🇫🇷 🤦♂
📲 What
As the title says
🤔 Why
The toggle wasn't very accessible since it didn't provide much context to the VoiceOver about what's being toggled ON/OFF
♿️ Accessibility
Navigate to
Manage pledge screenReward received OFF, double tap to toggle settingif the toggle is OFFReward received ON, double tap to toggle settingif the toggle is ON⏰ TODO