-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-328] Add min pledge label to pledge screen #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @dusi ! I just left a couple of minor comments 🥇
minValue | ||
) | ||
.map { project, min in | ||
localizedString( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string (untranslated) seems to be available. So I think we can replace this line with
Strings.The_minimum_pledge_is(min_pledge: Format.currency(min, country: project.country, omitCurrencyCode: false))
self.titleLabel, | ||
self.adaptableStackView, | ||
self.minPledgeAmountLabel, | ||
UIView(frame: .zero) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this was already merged, but I wonder if creating a variable to better describe what exactly the UIView(frame: .zero)
is would be more readable.
Something like:
let spacer (or whatever name) = UIView(frame: .zero)
_ = ([
self.titleLabel,
self.adaptableStackView,
self.minPledgeAmountLabel,
spacer
], self.rootStackView)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📲 What
Adds min pledge amount label with description of what the minimum amount is.
🤔 Why
This is a product requirement.
🛠 How
Simply adds label and shows/hides it based on whether it is a reward or no reward (hidden for no rewards).
👀 See
♿️ Accessibility
✅ Acceptance criteria
pledge screen)
⏰ TODO