[NT-357][NT-358] Change Payment Method UI #887
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| import KsApi | ||
| import Library | ||
| import Prelude | ||
| import Prelude_UIKit | ||
| import UIKit | ||
|
|
||
| final class PledgeAmountSummaryViewController: UIViewController { | ||
| // MARK: Properties | ||
|
|
||
| private lazy var pledgeAmountLabel: UILabel = { UILabel(frame: .zero) }() | ||
| private lazy var pledgeAmountStackView: UIStackView = { UIStackView(frame: .zero) }() | ||
| private lazy var pledgeLabel: UILabel = { UILabel(frame: .zero) }() | ||
| private lazy var rootStackView: UIStackView = { UIStackView(frame: .zero) }() | ||
| private lazy var shippingAmountLabel: UILabel = { UILabel(frame: .zero) }() | ||
| private lazy var shippingLocationLabel: UILabel = { UILabel(frame: .zero) }() | ||
| private lazy var shippingLocationStackView: UIStackView = { UIStackView(frame: .zero) }() | ||
|
|
||
| private let viewModel: PledgeAmountSummaryViewModelType = PledgeAmountSummaryViewModel() | ||
|
|
||
| // MARK: Life cycle | ||
|
|
||
| public func configureWith(_ project: Project) { | ||
| self.viewModel.inputs.configureWith(project) | ||
| } | ||
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
|
|
||
| self.configureSubviews() | ||
| self.bindViewModel() | ||
|
There was a problem hiding this comment. Isn't this happening through our swizzle thingys? 🤔 There was a problem hiding this comment. Indeed, thanks. |
||
|
|
||
| self.viewModel.inputs.viewDidLoad() | ||
| } | ||
|
|
||
| // MARK: Styles | ||
|
|
||
| override func bindStyles() { | ||
| super.bindStyles() | ||
|
|
||
| _ = self.pledgeAmountStackView | ||
| |> checkoutAdaptableStackViewStyle( | ||
| self.traitCollection.preferredContentSizeCategory.isAccessibilityCategory | ||
|
There was a problem hiding this comment. Can we declare local variable and reuse it (since we're using it twice here)? let isAccessibilityCategory = self.traitCollection.preferredContentSizeCategory.isAccessibilityCategory
...
checkoutAdaptableStackViewStyle(isAccessibilityCategory) |
||
| ) | ||
|
|
||
| _ = self.rootStackView | ||
| |> rootStackViewStyle | ||
|
|
||
| _ = self.shippingLocationStackView | ||
| |> checkoutAdaptableStackViewStyle( | ||
| self.traitCollection.preferredContentSizeCategory.isAccessibilityCategory | ||
| ) | ||
|
|
||
| _ = self.pledgeLabel | ||
| |> pledgeLabelStyle | ||
|
|
||
| _ = self.pledgeAmountLabel | ||
| |> amountLabelStyle | ||
|
|
||
| _ = self.shippingLocationLabel | ||
| |> shippingLocationLabelStyle | ||
|
|
||
| _ = self.shippingAmountLabel | ||
| |> amountLabelStyle | ||
| } | ||
|
|
||
| // MARK: View model | ||
|
|
||
| override func bindViewModel() { | ||
| super.bindViewModel() | ||
|
|
||
| self.pledgeAmountLabel.rac.attributedText = self.viewModel.outputs.pledgeAmountText | ||
| self.shippingAmountLabel.rac.attributedText = self.viewModel.outputs.shippingAmountText | ||
| self.shippingLocationLabel.rac.text = self.viewModel.outputs.shippingLocationText | ||
| self.shippingLocationStackView.rac.hidden = self.viewModel.outputs.shippingLocationStackViewIsHidden | ||
| } | ||
|
|
||
| // MARK: Functions | ||
|
|
||
| private func configureSubviews() { | ||
| _ = (self.rootStackView, self.view) | ||
| |> ksr_addSubviewToParent() | ||
| |> ksr_constrainViewToEdgesInParent() | ||
|
|
||
| _ = ([self.pledgeLabel, self.pledgeAmountLabel], self.pledgeAmountStackView) | ||
| |> ksr_addArrangedSubviewsToStackView() | ||
|
|
||
| _ = ([self.shippingLocationLabel, self.shippingAmountLabel], self.shippingLocationStackView) | ||
| |> ksr_addArrangedSubviewsToStackView() | ||
|
|
||
| _ = ([ | ||
| self.pledgeAmountStackView, | ||
| self.shippingLocationStackView | ||
| ], self.rootStackView) | ||
| |> ksr_addArrangedSubviewsToStackView() | ||
| } | ||
| } | ||
|
|
||
| // MARK: Styles | ||
|
|
||
| private let amountLabelStyle: LabelStyle = { label in | ||
| label | ||
| |> \.adjustsFontForContentSizeCategory .~ true | ||
|
There was a problem hiding this comment. Do we also need to set font? 🤔 There was a problem hiding this comment.
|
||
| |> \.textAlignment .~ NSTextAlignment.right | ||
| |> \.isAccessibilityElement .~ true | ||
| |> \.minimumScaleFactor .~ 0.75 | ||
| } | ||
|
|
||
| private let pledgeLabelStyle: LabelStyle = { label in | ||
| label | ||
| |> \.textColor .~ UIColor.ksr_dark_grey_500 | ||
| |> \.font .~ UIFont.ksr_subhead().bolded | ||
| |> \.adjustsFontForContentSizeCategory .~ true | ||
| |> \.text %~ { _ in Strings.Pledge() } | ||
| } | ||
|
|
||
| private let rootStackViewStyle: StackViewStyle = { stackView in | ||
| stackView | ||
| |> checkoutStackViewStyle | ||
| |> \.spacing .~ Styles.grid(3) | ||
| } | ||
|
|
||
| private let shippingLocationLabelStyle: LabelStyle = { label in | ||
| label | ||
| |> \.textColor .~ UIColor.ksr_dark_grey_500 | ||
| |> \.font .~ UIFont.ksr_subhead().bolded | ||
| |> \.adjustsFontForContentSizeCategory .~ true | ||
| |> \.numberOfLines .~ 0 | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just copy-pasting the required views from
ManagePledgeSummaryView.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on Zoom, I'll create a follow-up PR to incorporate this as as subview of
ManagePledgeSummaryViewControllerto promote reuse.