[NT-424] Migrate HockeyApp to AppCenter #910

justinswart · 2019-10-25T02:29:32Z

📲 What

Replaces HockeyApp with Microsoft's new AppCenter SDK.

Note: So far I have only migrated our alpha target in order to test this end-to-end. Once we're satisfied we should migrate our beta and production targets.

🤔 Why

HockeyApp is being sunset on Nov 16 2019. We're required to migrate to AppCenter to continue using the platform for distributing our internal alpha and beta builds.

🛠 How

Removed all references to Hockey in our codebase, secrets, circle.yml, Fastfile.
Configured AppCenter as closely as possible to how we had been configuring Hockey. However, some configuration properties that we had before don't seem to be available on AppCenter.
Added the AppCenter Fastlane plugin for distributing alpha and beta builds via CircleCI.
Added api token to secrets: https://github.com/kickstarter/native-secrets/pull/61

✅ Acceptance criteria

Distribute an alpha locally via fastlane using the following commands:

agvtool new-version -all $(($(date +%s)/100))
bundle exec fastlane alpha_gym
bundle exec fastlane alpha_appcenter

This should upload an Alpha build to AppCenter and it should be visible in the dashboard.
Push to alpha-dist-<something>. This will generate an ad hoc alpha build on CircleCI and distribute that to AppCenter.

⏰ TODO

Move Beta and Production apps over to AppCenter and generate their API tokens.

justinswart · 2019-10-25T02:31:32Z

.circleci/config.yml

@@ -44,15 +41,6 @@ jobs:
          keys:
            - fabric-sdk-cache-{{ checksum "fabric_version.txt" }}

-      - run:
-          name: Store Hockey SDK Version


The AppCenter SDK is managed via Carthage, no need to cache this separately.

justinswart · 2019-10-25T02:32:21Z

Kickstarter-iOS/AppDelegate.swift

-        manager.authenticator.authenticateInstallation()
+      .observeValues { data in
+        let customProperties = MSCustomProperties()
+        customProperties.setString(data.userName, forKey: "userName")


Added this because there doesn't appear to be a similar userName property like BITHockeyManager had before.

justinswart · 2019-10-25T02:33:35Z

Kickstarter-iOS/AppDelegate.swift

+          withServices: [
+            MSAnalytics.self,
+            MSCrashes.self,
+            MSDistribute.self


Need to confirm that MSDistribute works correctly for us. In the set up docs it mentions adding the app secret to Info.plist which is obviously problematic for us. So I didn't do it but I'm not sure if it will cause issues.

ksr-ci-bot · 2019-10-25T18:41:08Z

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

justinswart · 2019-10-28T21:45:43Z

Kickstarter-iOS/Info.plist

@@ -31,6 +31,7 @@
 		<dict>
 			<key>CFBundleURLSchemes</key>
 			<array>
+				<string>appcenter-$(APPCENTER_$(APPCENTER_SCHEME_NAME)_API_TOKEN)</string>


@Scollaco @ifbarrera This accesses the environment var for the API token based on an environment var for this configuration.

So for our alpha target the concatenated environment var is APPCENTER_ALPHA_API_TOKEN and in this var name ALPHA is a variable based on APPCENTER_SCHEME_NAME which is a user-defined variable in our build settings.

These docs mention that we need to have the secret in the Info.plist

justinswart · 2019-10-28T21:46:50Z

Kickstarter.xcodeproj/project.pbxproj

 			isa = XCBuildConfiguration;
 			buildSettings = {
+				APPCENTER_SCHEME_NAME = ALPHA;


justinswart · 2019-10-29T22:18:05Z

@Scollaco this is ready for re-review. Just note, where previously I was calling it an API token per app, it's actually just one API token and rather a secret per app. I've also since removed the production target from being submitted to AppCenter. We will only use it for alpha and beta distribution.

Scollaco · 2019-10-30T15:32:13Z

@Scollaco this is ready for re-review. Just note, where previously I was calling it an API token per app, it's actually just one API token and rather a secret per app. I've also since removed the production target from being submitted to AppCenter. We will only use it for alpha and beta distribution.

Ok, I will test now and approve once it works. Could you please merge the secrets PR?

Scollaco

🚀

justinswart added 3 commits October 24, 2019 18:23

Replace HockeyApp with AppCenter

950e178

Update Circle config

aba73cf

Update secrets template

6d7239c

justinswart requested review from ifbarrera and Scollaco October 25, 2019 02:29

justinswart assigned Scollaco Oct 25, 2019

justinswart commented Oct 25, 2019

View reviewed changes

Merge branch 'master' into migrate-hockey-app-center

4b0f797

justinswart added 4 commits October 28, 2019 11:42

Merge branch 'master' into migrate-hockey-app-center

2a76323

Add AppCenter secret to Info.plist

e67bf84

Revert build number

ecc8451

Fix indentation

9e9845c

justinswart commented Oct 28, 2019

View reviewed changes

justinswart added the blocked a PR that is blocked for external reasons label Oct 28, 2019

justinswart added 3 commits October 28, 2019 16:47

Merge branch 'master' into migrate-hockey-app-center

231c9de

Merge branch 'master' into migrate-hockey-app-center

86d436f

Remove AppCenter for release target, update env var name

a061647

justinswart added needs review and removed blocked a PR that is blocked for external reasons labels Oct 29, 2019

Fix typo

298ccca

Scollaco approved these changes Oct 30, 2019

View reviewed changes

justinswart merged commit dfc6fde into master Oct 30, 2019

justinswart deleted the migrate-hockey-app-center branch October 30, 2019 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NT-424] Migrate HockeyApp to AppCenter #910

[NT-424] Migrate HockeyApp to AppCenter #910

justinswart commented Oct 25, 2019

justinswart Oct 25, 2019

justinswart Oct 25, 2019

justinswart Oct 25, 2019

ksr-ci-bot commented Oct 25, 2019

justinswart Oct 28, 2019

justinswart Oct 28, 2019

justinswart Oct 28, 2019

justinswart commented Oct 29, 2019

Scollaco commented Oct 30, 2019

Scollaco left a comment

[NT-424] Migrate HockeyApp to AppCenter #910

[NT-424] Migrate HockeyApp to AppCenter #910

Conversation

justinswart commented Oct 25, 2019

📲 What

🤔 Why

🛠 How

✅ Acceptance criteria

⏰ TODO

justinswart Oct 25, 2019

Choose a reason for hiding this comment

justinswart Oct 25, 2019

Choose a reason for hiding this comment

justinswart Oct 25, 2019

Choose a reason for hiding this comment

ksr-ci-bot commented Oct 25, 2019

justinswart Oct 28, 2019

Choose a reason for hiding this comment

justinswart Oct 28, 2019

Choose a reason for hiding this comment

justinswart Oct 28, 2019

Choose a reason for hiding this comment

justinswart commented Oct 29, 2019

Scollaco commented Oct 30, 2019

Scollaco left a comment

Choose a reason for hiding this comment