[NT-484] Tracking event for Cancel Pledge #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cancel-pledge-event
Scollaco
reviewed
Oct 29, 2019
| self.vm.inputs.configure(with: .template, backing: .template) | ||
| self.vm.inputs.viewDidLoad() | ||
|
|
||
| self.cancelPledgeButtonEnabled.assertValues([true]) |
There was a problem hiding this comment.
The cancelPledgeButton status is already being tested in other place and it's not so useful here since you're only testing the tracking. Instead, I would replace this line with XCTAssertEqual([], self.trackingClient.events) to prove that the event is only tracked after the button is tapped.
Scollaco
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Improvements in monitoring user behavior for v1 checkout. This tracks canceled pledges.
🤔 Why
We now have the
Cancel Pledge Button Clickedevent✅ Acceptance criteria
Cancel Pledge. Tap onYes, Cancel itbutton and you should see the event, "Cancel Pledge Button Clicked" triggered.